Improve audio sampling at non-60 fps targets #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should remedy a subtle issue with audio and configurable framerate targets.
also makes extremely high/slow speeds sound really funny instead of horribly broken, so that's a plus.
shouldn't improve audio during framerate dips, unfortunately.
I cheated and capped the sample length at 1024 to keep it from crashing, that might cause issues, but i think it should only matter with a significantly increased framerate target? ie. fast forward.
was a very hastily/lazily assembled fix, so if you want something improved or changed feel free to ask.